Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix needsOuterIfReferenced #17159

Merged
merged 2 commits into from
Apr 22, 2023
Merged

Fix needsOuterIfReferenced #17159

merged 2 commits into from
Apr 22, 2023

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 28, 2023

#17135 shows that traits also need an outer accessor if they are in a toplevel method (or lazy val).

Fixes #17135

@odersky
Fix needsOuterIfReferenced
d1255f3 
scala#17135 shows that traits also need an outer accessor if they are in a toplevel
method (or lazy val).

Fixes scala#17135
@odersky odersky requested a review from bishabosha March 28, 2023 10:23
@odersky odersky assigned bishabosha and SethTisue and unassigned bishabosha Mar 28, 2023
@odersky odersky requested review from SethTisue and removed request for bishabosha March 28, 2023 10:24
@dwijnand
Copy link
Member

This breaks bootstrapping, it seems.

Error:  SI-5604: found package class where package object expected: This(Ident(mutable))
Error while emitting ArrayBuffer.scala

  unhandled exception while running genBCode on /home/runner/work/dotty/dotty/out/bootstrap/stdlib-bootstrapped/scala-3.3.1-RC1-bin-SNAPSHOT-nonbootstrapped/src_managed/main/scala-library-src/scala/collection/mutable/ArrayBuffer.scala

@SethTisue SethTisue assigned dwijnand and unassigned SethTisue Apr 5, 2023
@SethTisue SethTisue requested a review from dwijnand April 5, 2023 11:06
@odersky
Copy link
Contributor Author

odersky commented Apr 22, 2023

@dwijnand ping for review

@dwijnand dwijnand merged commit ccf38be into scala:main Apr 22, 2023
@dwijnand dwijnand deleted the fix-17135 branch April 22, 2023 16:16
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@SethTisue SethTisue Awaiting requested review from SethTisue

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

An object in sealed trait inside of a function crashes the compiler
5 participants
@odersky @dwijnand @SethTisue @Kordyjan @bishabosha