New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Fix: Correct the navigation to anchor" to LTS #18985

Merged

Kordyjan merged 1 commit into release-3.3.2 from lts-17910

Nov 21, 2023

Contributor

Kordyjan commented Nov 17, 2023

Backports #17910 to the LTS branch.

PR submitted by the release tooling.
[skip ci]


          Fix: Correct the navigation to anchor (#17910)

bbf95d9

The browser compatibility of
[`location.hash`](https://developer.mozilla.org/en-US/docs/Web/API/Location/hash)
seems to be out of date. That's why in this fix, I suggest using
[`history.replaceState`](https://developer.mozilla.org/en-US/docs/Web/API/History/replaceState).

## Before:


https://github.com/lampepfl/dotty/assets/44496264/a1399b0b-e4e8-4754-b146-661b59a01824

## After:


https://github.com/lampepfl/dotty/assets/44496264/22f38852-0cc5-48eb-a6e7-699f11628401

Fixes: #17182
[Cherry-picked 7694985]

Base automatically changed from lts-17926 to release-3.3.2

November 21, 2023 11:12

Contributor Author

Kordyjan commented Nov 21, 2023

No new regressions found in https://virtuslab.github.io/community-build3/2023/11/17/3.3.2-rc1-bin-57c5334015ee4aa800b24b4f8691a076f20d9069.html. Merging, up to PR 17991.

Kordyjan merged commit ee838f7 into release-3.3.2

32 of 33 checks passed

Kordyjan deleted the lts-17910 branch

November 21, 2023 11:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet