[WIP] Normalize for underlyingClassRef #20183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests scala#13433 with a classpath dependency
Test scala#15827 with a classpath dependency
EugeneFlesselle
force-pushed
the
underlyingClassRef-norm
branch
from
784e5af to
4523dcb
Compare
|
This did not cause but lead me to uncover #20184, we might want to fix that before this PR. |
EugeneFlesselle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #20180
It fixes the version of #15827 with a classpath decency and does not break anything else, but I'm not that confident about making changes to
underlyingClassRef.Then again, having its result differ when using a classpath dependency from with joint compilation isn't great either.
This is part of the fixes needed to not simplify AppliedTypes if
ctx.mode.is(Type).