Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "SimplePattern errors should now be recovered as wildcard instead of unimplemented expr" to LTS #22110

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Backport "SimplePattern errors should now be recovered as wildcard instead of unimplemented expr" to LTS #22110

merged 1 commit into from
Dec 4, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #21438 to the 3.3.5.

PR submitted by the release tooling.
[skip ci]

@WojciechMazur WojciechMazur force-pushed the backport-lts-3.3-21404 branch from d76e8f6 to 2992889 Compare December 3, 2024 20:42
@rochala @WojciechMazur
SimplePattern errors should now be recovered as wildcard instead of u…
72bce19 
…nimplemented expr (#21438)

We should not emit more errors that came from our error recovery term
trees.

Previously, we've recovered those situations with unimplemented
expression term added in #19103
and before that it was just a `null`
[Cherry-picked f036195]
@WojciechMazur WojciechMazur force-pushed the backport-lts-3.3-21438 branch from 28d1397 to 72bce19 Compare December 3, 2024 20:44
Base automatically changed from backport-lts-3.3-21404 to lts-3.3 December 4, 2024 17:19
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to backport-lts-3.3-21857.

Reference

@WojciechMazur WojciechMazur merged commit 2271639 into lts-3.3 Dec 4, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the backport-lts-3.3-21438 branch December 4, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechMazur @rochala