Fix layout of released SDK archives, restore intermediate top-level directory #22199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…la3-{{ scala-version }}`
WojciechMazur
added
the
backport:nominated
hamzaremmal
reviewed
Dec 16, 2024
WojciechMazur
added a commit
that referenced
this pull request
Dec 30, 2024
…directory (#22199) Fixes #22194 Restores top-level directory `scala3-${version}` that is present in artifacts published before Scala 3.6, removed during hotfix 3.6.1 release. We now follow the [Well formed SDK archives layout](https://github.com/sdkman/sdkman-cli/wiki/Well-formed-SDK-archives). Removing the top-level directory even though at first glance looked like an improvement was in fact introducing problems to multiple package managers and build tools. [Cherry-picked 5b3d82a]
WojciechMazur
added
backport:done
SethTisue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22194
Restores top-level directory
scala3-${version}that is present in artifacts published before Scala 3.6, removed during hotfix 3.6.1 release.We now follow the Well formed SDK archives layout. Removing the top-level directory even though at first glance looked like an improvement was in fact introducing problems to multiple package managers and build tools.
Follow up actionable: