Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multi-stage example to reference latest example from Macros section #22231

Closed
wants to merge 3 commits into from

Conversation

ozenzin
Copy link
Contributor

@ozenzin ozenzin commented Dec 18, 2024

Current Example is based on obsolete content of macros-spec.md (updated since commit d8c9714) . This small change brings in the updated content here as well.

Attn @nicolasstucki

…ction

Current Example is based on obsolete content of macros-spec.md (which was updated in commit d8c9714) . This small change brings in the updated content here as well.
Copy link
Contributor

@jchyb jchyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for submitting the PR. Just one new inconsistency I noticed

@jchyb
Copy link
Contributor

jchyb commented Dec 19, 2024

There are some test failures, but they seem unrelated. They should disappear after rerunning the CI

Missed a wording still referencing obsolete content (thanks code reviewers for pointing it out)
@tgodzik
Copy link
Contributor

tgodzik commented Dec 20, 2024

The CI seems to be still broken and when I tried to rebase I got conflicts in places no changes were done. Did you check out from the main branch? You might need to redo the PR by doing it.

@ozenzin
Copy link
Contributor Author

ozenzin commented Dec 20, 2024

The CI seems to be still broken and when I tried to rebase I got conflicts in places no changes were done. Did you check out from the main branch? You might need to redo the PR by doing it.

Thanks Tomasz. I've created my PR online following links from the online doc. I believe it refers scala:language-reference-stable branch, which became current base branch for my PR. I'll try to re-base it to master, and if not - close this PR and open a new one. Thanks for taking a look and pointing it out!

@ozenzin
Copy link
Contributor Author

ozenzin commented Dec 20, 2024

Closing this PR, and open a new (properly based on branch main): #22256

@ozenzin ozenzin closed this Dec 20, 2024
@ozenzin ozenzin deleted the patch-1 branch December 20, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants