Make Ref.apply() return trees usable in the largest scope possible #22240
+105
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously for symbols contained in objects (prefixed by, let's say, 'pre'), we would return: * an Ident if pre contained only static object and packages; * Select(This(moduleClassSymbol), sym) if a prefix contained a class. However, this meant that in the second case, the generated tree would require the macro to be expanded inside of the object, even though it should be enough to just expand inside of the innermost class. This was unexpected and confusing, so it was changed to not return innermost module classes wrapped with This().
jchyb
commented
Jan 2, 2025
| @@ -1950,7 +1950,6 @@ object SymDenotations { | |||
|
|
|||
| /** The this-type depends on the kind of class: | |||
| * - for a package class `p`: ThisType(TypeRef(Noprefix, p)) | |||
| * - for a module class `m`: A term ref to m's source module. | |||
There was a problem hiding this comment.
Removed, as it has not been true since dc02760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for symbols contained in objects (prefixed by, let's say, 'pre'), we would return:
precontained only static object and packages;Select(This(moduleClassSymbol), sym)ifprecontained a class.However, this meant that in the second case, the generated tree would require the macro to be expanded inside of the object, even though it should be enough to just expand inside of the innermost class.
This was unexpected and confusing, so it was changed to not return innermost module classes wrapped with This().
Fixes #20349