Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak ExtensionNullifiedByMember #22268

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Dec 29, 2024

The warning accounted for an opaque receiver but not for opaque parameter types.

This commit warns only if corresponding parameters are both opaque (or both transparent).

The warning message about extensions that will never be selected has limited generality.

This commit addresses conversions to the receiver type.

Maybe the correct fix is "never say never".

Enhances the message noticed at #22267
Fixes #22279

@som-snytt som-snytt requested a review from sjrd December 30, 2024 20:18
@som-snytt
Copy link
Contributor Author

@sjrd requesting your (quick) review because this follows up #21825 which is on 3.6.3.

@sjrd sjrd merged commit d16453e into scala:main Jan 6, 2025
29 checks passed
@som-snytt som-snytt deleted the issue/22267-ext-msg branch January 6, 2025 17:26
@WojciechMazur WojciechMazur added this to the 3.6.4 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtensionNullifiedByMember false positive with opaque type
3 participants