chore: Add @nowarn annotation to LazyVals. #22270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
reviewed
Dec 30, 2024
Unsafe is planed to be removed in future Java version.
som-snytt
approved these changes
Dec 30, 2024
|
Not sure if dotty has the "nowarn suppresses no warnings" lint, but it would be nice to ensure clean compilation across JDK versions. Also not sure whether dotty exploits newer API or if releases are built under the |
|
Keep JEP 498: Warn upon Use of Memory-Access Methods in sun.misc.Unsafe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsafe is planned to be removed in future Java versions.
Motivication:
Makes it compile on JDK 23
refs: https://openjdk.org/jeps/471
Modification:
Add
@nowarn("cat=deprecation")Result:
Compiles successfully on JDK 23