Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback constraints in compareAppliedTypeParamRef #22339

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Jan 10, 2025

This PR adds a rollbackConstraintsUnless in compareAppliedTypeParamRef. It is required in case the call to directionalIsSubType introduces constraints and the call to directionalRecur returns false.

Fixes #20519

@mbovel mbovel requested a review from smarter January 10, 2025 16:36
@mbovel mbovel added the fasttrack Simple fix. Reviewer should merge or apply additional changes directly. label Jan 10, 2025
@smarter smarter merged commit 5369d1a into scala:main Jan 13, 2025
29 checks passed
@mbovel mbovel deleted the mb/20519 branch January 13, 2025 11:43
@WojciechMazur WojciechMazur added this to the 3.6.4 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing given instance for EitherT using type alias
3 participants