-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename unused
to ghost
#4061
Rename unused
to ghost
#4061
Conversation
I wouldn't make such a claim. Only one person complained which for me is more a sign that the name is not that controversial. Personally, I prefer |
I would change it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — both the changes and the strategy. Thanks for the prompt PR!
Given the size of the rename, I looked at current occurrences of unused
, and comparing them with the ones before unused
was merged. I used
vimdiff <(git grep unused compiler) <(git grep unused 2a85106974ce5620eabbf4658810ddb917465145 compiler)
, and inspecting the output of git grep unused
.
I like the strategy — either way we might still change the name, but at least the one we use has no obvious blockers.
I wouldn't make such a claim. Only one person complained which for me is more a sign that the name is not that controversial.
"Nobody" was hyperbole, but based on comments by both Martin and IIRC Nicholas (apart from me).
I just merged this, also to unblock the release (let me know if I was too hasty). For future discussion: the concept of "ghost" is also used by Liquid Haskell (and maybe @gsps's Liquid Scala), but for essentially the same thing: values that don't exist at runtime. So maybe @gsps is also interested? |
It is also related to F*'s Ghost monad and |
@allanrenucci Have you seen the poll: https://goo.gl/forms/UD44AfLUD3dkfnxs2 ? |
No description provided.