add readResolve to objects with serializable interface #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
May 3, 2018
smarter
reviewed
May 3, 2018
| symbolsToSynthesize flatMap syntheticDefIfMissing | ||
| val methods = symbolsToSynthesize flatMap syntheticDefIfMissing | ||
|
|
||
| def createReadResolveMethod: Tree = { |
There was a problem hiding this comment.
It'd be nice to extract the common code between this method and syntheticDef in a separate method somehow.
| cpy.Template(impl)(body = impl.body ++ syntheticMethods(ctx.owner.asClass)) | ||
| def addSyntheticMethods(impl: Template)(implicit ctx: Context) = { | ||
| val isSerializableObject = | ||
| (ctx.owner.is(Module) |
There was a problem hiding this comment.
To match scalac behavior, we should only do this for static objects (that is, objects which are not inside classes or methods), this can be checked using .isStatic.
| val isSerializableObject = | ||
| (ctx.owner.is(Module) | ||
| && ctx.owner.derivesFrom(defn.JavaSerializableClass) | ||
| && !ctx.owner.asClass.membersNamed(nme.readResolve).exists) |
There was a problem hiding this comment.
We should still emit our readResolve method if the user declared a readResolve method with a different signature (e.g. def readResolve(x: Int): AnyRef). We can filter for methods with (): AnyRef as signature by doing membersNamed(nme.readResolve).suchThat(_.signature == Signature(defn.AnyRefType, isJava = false)
ingarabr
force-pushed
the
read-resolve
branch
3 times, most recently
from
0072dc2 to
7702780
Compare
If the object implements the serializable interface and not includes the readResolve method then we add it. Since it's an object we reference it to the objects singleton instance. Resolves issue scala#4440
|
@smarter Have your comments been addressed? If yes please merge. |
|
I'll have a look next week, I think there's still one thing I wanted to do here. |
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 22, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serializable in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
|
I've opened a new PR adapted from this PR and scala/scala#7297 at #5775, so I'll close this one, thanks for your work @ingarabr ! |
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 22, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 22, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 22, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
pushed a commit
to smarter/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 25, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 26, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 2, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 2, 2019
In scala#4450 and Scala 2.12, readResolve is used to make sure deserializing an object returns the singleton instance of the object, but this doesn't prevent the fields of the objects from being serialized in the first place even though they're not used. Scala 2.13 switched to using writeReplace to completely bypass serialization of the object in scala/scala#7297. This commit adapts this to Dotty. Co-Authored-By: Ingar Abrahamsen <[email protected]> Co-Authored-By: Jason Zaugg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the object implements the serializable interface and not includes the
readResolve method then we add it. Since it's an object we reference it
to the objects singleton instance.
Resolves issue #4440