Stub implementation of xml interpolator #5096
Conversation
allanrenucci
force-pushed
the
xml-interpolation
branch
3 times, most recently
from
facdf69 to
e07e72e
Compare
| List(Typed(Repeated(values), _)))) if values.forall(isStringConstant) => | ||
| values.collect { case Literal(Constant.String(value)) => value } | ||
| case _ => | ||
| ??? |
There was a problem hiding this comment.
This should only happen if you write explicitly something like
val sc = new StringContext(...)
new XmlQuote(sc).xml(...)you can emit an error in this case using new scala.quoted.QuotedError(...) which will be translated into a compilation error.
There was a problem hiding this comment.
Thanks. I think we are still missing the ability to report an error at a custom position
There was a problem hiding this comment.
Yes we are. Should not be hard to add.
| val parts = ctx.toTasty match { | ||
| case Inlined(_, _, | ||
| Apply( | ||
| Select(Select(Select(Ident("_root_"), "scala", _), "StringContext", _), "apply", _), |
There was a problem hiding this comment.
In tasty.definition you should have types or symbols for root and scala. You should be able to test this in the guard.
There was a problem hiding this comment.
Doesn't look simpler. It is more correct?
There was a problem hiding this comment.
Then this is fine. I expected it to look simpler
|
|
||
| case class Xml(parts: String, arg: Any) | ||
|
|
||
| class XmlQuote(ctx: StringContext) { |
There was a problem hiding this comment.
Shouldn't this class extend AnyVal?
There was a problem hiding this comment.
I doesn't matter for performance. The code is elided by the macro. So the simpler, the better
There was a problem hiding this comment.
Even the allocation of the XmlQuote is elided?
There was a problem hiding this comment.
Actually my intuition (based on how Scala 2 macros work) was wrong. The receiver of the macro doesn't get elided. I opened #5110
allanrenucci
force-pushed
the
xml-interpolation
branch
from
e07e72e to
92ab218
Compare
|
@nicolasstucki @biboudis I think this is good enough as a test and a proof of concept. Real development is happening here |
| case class Xml(parts: String, args: List[Any]) | ||
|
|
||
| // Ideally should be an implicit class but the implicit conversion | ||
| // has to be a rewrite method |
There was a problem hiding this comment.
Good point, I think this is the best solution. Otherwise, we would need something like implicit rewrite class XmlQuote(...). Maybe with proper extension methods this will not be an issue.
|
We will still need to enable the test when #5119 is fixed. |
No description provided.