Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5119: Get underlying argument for synthetic local values #5189

Merged
merged 4 commits into from
Oct 2, 2018
Merged

Fix #5119: Get underlying argument for synthetic local values #5189

merged 4 commits into from
Oct 2, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

allanrenucci
allanrenucci previously approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would also add a test for reordered named argument

@nicolasstucki
Copy link
Contributor Author

@allanrenucci could you review the last 3 commits I changed the way we handle named arguments and improved the performance of the code.

@nicolasstucki nicolasstucki dismissed allanrenucci’s stale review October 2, 2018 12:35

Code has some additions

@nicolasstucki nicolasstucki merged commit e4735d2 into scala:master Oct 2, 2018
@nicolasstucki nicolasstucki deleted the fix-#5119 branch October 2, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci approved these changes

Assignees

@allanrenucci allanrenucci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @allanrenucci