String f interpolator macro
#6540
Conversation
To ask : how to import the macro without copying it? why do this import fail?
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
|
@alemannosara I added some commits to reconcile some differences with master. Unfortunately, this is not enough and you will need to rebase on master. Though now the tests that were failing to compile are now compiling. But there are still runtime errors. |
|
I will let you rebase and fix the rest of the tests |
Apply the comments given by @nicolasstucki
|
@nicolasstucki Thank you for your comments. I applied them all. |
|
@alemannosara I compiled it on my machine and did not have problems with imports. Maybe you should clean your project and restart sbt. |
This reverts commit e6caa6f.
|
@alemannosara could you squash and then rebase this PR |
I have rebased the PR. Could I "Squash And Merge" when merging ? |
|
@alemannosara could you sign the CLA https://www.lightbend.com/contribute/cla/scala |
I have just signed it |
|
The CLA checks out https://www.lightbend.com/contribute/cla/scala/check/alemannosara, bot is not updating. |
Remove code duplication
modify imports
No description provided.