Fix #6622: Add code interpolation
#6661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Jun 11, 2019
rtfpessoa
force-pushed
the
add-code-interpolation
branch
from
7899ae0 to
78e65e4
Compare
Allows to get string representations for code passed in the interpolated
values
```scala
inline def logged(p1: => Any) = {
val c = code"code: $p1"
val res = p1
(c, p1)
}
logged(indentity("foo"))
```
is equivalent to:
```scala
("code: indentity("foo")", indentity("foo"))
```
rtfpessoa
force-pushed
the
add-code-interpolation
branch
from
78e65e4 to
3142de6
Compare
nicolasstucki
approved these changes
Jun 11, 2019
|
Thanks a lot to @nicolasstucki and @biboudis for the help, coaching and patience. |
|
Nice work! |
|
What is the rational to implement this in the compiler instead of as a macro? |
|
As we plan to use this feature inside the standard library we cannot use a macro due to potential bootstrapping issues. |
|
Thanks @rtfpessoa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to get string representations for code passed in the interpolated
values
is equivalent to: