Handle nullability info in by-name arguments #7727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeln
approved these changes
Dec 13, 2019
Implements the scheme described in my comment to scala#7546. - We type check an argument without or with flow info, depending on whether the function part of the application is known to take a call-by-name parameter. If we know nothing about the function part, we assume call-by-value. - At the end of type checking an application, if the argument is known to be by-name, remove all x.$asInstanceOf$[T] casts in the argument where x is a mutable variable, and run the type assigner (not the type checker!) again on the result. If this succeeds and gives a type that is still compatible with the formal parameter type, we are done. - Otherwise, issue an error saying that the argument cannot be treated as call-by-name since it contains flow-assumptions about mutable variables. As a remedy, suggest to wrap the argument in a `scala.compiletime.byName(...)` call. Here, `byName` is defined as follws: ``` inline def byName[T](x: => T): T ``` Wrapping an argument with byName means that we know statically that it is passed to a by-name parameter, so it will be typechecked without flow info.
odersky
force-pushed
the
change-byname-nullable
branch
from
a0e3525 to
df71c9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the scheme described in my comment to #7546.
depending on whether the function part of the application
is known to take a call-by-name parameter. If we know nothing
about the function part, we assume call-by-value.
known to be by-name, remove all x.$asInstanceOf$[T] casts in the
argument where x is a mutable variable, and run the (re-)typer again
on the result. If this succeeds and gives a type that is still compatible
with the formal parameter type, we are done.
as call-by-name since it contains flow-assumptions about mutable variables.
As a remedy, suggest to wrap the argument in a
scala.compiletime.byName(...)call. Here,
byNameis defined as follws:it is passed to a by-name parameter, so it will be typechecked without
flow info.