Upgrade to Yarn 4 #8061
Upgrade to Yarn 4 #8061
Conversation
There was a problem hiding this comment.
I slightly grouped some of the more obvious ignored files. Only moved stuff around.
| **/screenshots/*.diff.png | ||
| **/screenshots/*.new.png | ||
|
|
||
| # Yarn |
There was a problem hiding this comment.
Added a new yarn group as described in their docs: https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
.gitignore
Outdated
| !.yarn/releases | ||
| !.yarn/sdks | ||
| !.yarn/versions | ||
| tools/proxy/.yarn/install-state.gz |
There was a problem hiding this comment.
why not add a wildcard à la tools/proxy.yarn/*?
| @@ -0,0 +1 @@ | |||
| nodeLinker: node-modules | |||
There was a problem hiding this comment.
out of curiousity: did you try other linkers? we don't need to switch in this pr, but I'm wondering if it's complicated.
There was a problem hiding this comment.
Not yet. I wasn't sure how this works together with webpack/esbuild.
| "resolutions": { | ||
| "**/mini-store": "^1.1.0", | ||
| "**/redux": "3.7.2", | ||
| "**/rc-resize-observer": "^1.4.0", | ||
| "**/rc-util": "^5.39.1" | ||
| }, |
There was a problem hiding this comment.
are resolutions not supported, anymore? I'm wondering whether the reasons, why we added these initially, are really obsolete now.
There was a problem hiding this comment.
They were outremoved. I already removed redux, rc-* on the react-18 branch, leaving only mini-store. I cannot find a reference to mini-store either... So this should be fine.
Updated yarn to version 4 following the offical migration guide.. Except for the
.gitignorefile all files were auto-created/auto-updated.Other changes:
yarninstallation of thecommand-JS-package during the SBT asset compilation. The package is already installed as a dev-dependency of the main yarn WK installation.Restore Cache(51s) andSave Cache(2 min) are slower than justyarn installincluding the download (18s).Steps to test:
node18+ is installedcorepack enableyarn installIssues:
(Please delete unneeded items, merge only when none are left open)