Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binaries release on Windows #1306

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Fix binaries release on Windows #1306

merged 1 commit into from
Jun 10, 2020

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 9, 2020

No description provided.

Duhemm
Duhemm approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@Duhemm Duhemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @tgodzik !

@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 9, 2020

I was hoping that this would solve the issues with the releases that we were having, but not sure anymore :/

It seems that we are being hit by sbt/sbt#5587 despite using a totally different version of sbt.
But it might be that we are using the default sbt version from the launcher in that particular job. I will need to investigate a bit.

@tgodzik tgodzik force-pushed the bump-sbt-version branch from c14543b to a8d1fc7 Compare June 9, 2020 17:21
@tgodzik tgodzik changed the title Update sbt version to 1.3.10 Fix binaries release on Windows Jun 9, 2020
@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 9, 2020

@jvican Not 100% sure if it's the case but I am thinking that when we run :

          "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars64.bat" &&
          "%CD%"\bin\sbt-ci-release.bat

the current directory is not that of the project, so we are not detecting the /project/build.properties file and using the default 1.3.12, which would explain the issue.

I added -sbt-version that should help out if that is the case

@tgodzik tgodzik requested a review from jvican June 9, 2020 17:24
@jvican
Copy link
Contributor

jvican commented Jun 10, 2020

Let’s give it a try thanks for investigating @tgodzik !

@jvican jvican merged commit 78d5ddd into scalacenter:master Jun 10, 2020
@jvican jvican added build bug A defect or misbehaviour. labels Jun 10, 2020
@tgodzik tgodzik deleted the bump-sbt-version branch June 10, 2020 09:44
@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 10, 2020

It doesn't seem to have helped, I will investigate further today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvican jvican jvican approved these changes

@Duhemm Duhemm Duhemm approved these changes

Assignees
No one assigned
Labels
bug A defect or misbehaviour. build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgodzik @jvican @Duhemm