Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop coursier '--scala-version' when launching bloop console #1329

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Drop coursier '--scala-version' when launching bloop console #1329

merged 1 commit into from
Jun 25, 2020

Conversation

fooblahblah
Copy link
Contributor

Fixes #1301 (bloop console exits with ClassNotFound exception).

Note, I manually tested 2.13 and 2.12 with this change. I'm not sure this ever worked for 2.11 or 2.10?

Copy link
Contributor

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution and looking into this! 👍 I remember this was not working for 2.11 in the past but seems like the bug we run into is fixed in the latest release and we can do without this argument.

@jvican jvican merged commit 93086c4 into scalacenter:master Jun 25, 2020
@alexarchambault
Copy link
Contributor

I'm kind of surprised --scala-version has to be removed… I would actually expect things to fail sometimes without it (because this can bring artifacts corresponding to different full scala versions). Did you compare the class paths you get with and without the --scala-version? You can get these class paths by passing -v -v to launch, or using fetch instead of launch (and removing the --main-class argument).

@jvican
Copy link
Contributor

jvican commented Jun 26, 2020

Do you recommend reverting this change and looking into what's happening @alexarchambault? I'm concerned here that not using --scala-version might disrupt the ammonite console integration for other users after reading your comment.

@alexarchambault
Copy link
Contributor

Do you recommend reverting this change and looking into what's happening?

I don't know if it should be reverted right now (it seems this fixes things in some cases), but maybe be prepared to revert it if anyone complains?

It'd be nice to look more closely at what happened, yes. Like looking at the arguments passed to coursier and the class path it computed, and comparing with and without --scala-version.

@jvican jvican added bug A defect or misbehaviour. task / console labels Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect or misbehaviour. task / console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bloop console exits with NoSuchMethodError
3 participants