Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESModule to Scala.js #1415

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Add ESModule to Scala.js #1415

merged 1 commit into from
Nov 27, 2020

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Nov 26, 2020

No description provided.

@lolgab lolgab marked this pull request as ready for review November 26, 2020 22:05
sjrd
sjrd approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I assume that includes all the places where CommonJSModule was mentioned.

@lolgab
Copy link
Contributor Author

lolgab commented Nov 27, 2020

Double-checked and it includes all the places where CommonJSModule was mentioned.

tgodzik
tgodzik approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! All seems good and tests were flaky previously,

@tgodzik tgodzik merged commit 245fa02 into scalacenter:master Nov 27, 2020
@lolgab lolgab deleted the add-esmodule branch November 27, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolgab @sjrd @tgodzik