Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle enhancements #1442

Merged
merged 4 commits into from
Jan 15, 2021
Merged

Conversation

Arthurm1
Copy link
Contributor

Handle annotationProcessor keyword in Gradle dependencies

Handle java.srcDirs and resources.srcDirs being the same

Add a few missing tests to Gradle bloopInstall settings

Don't save empty projects settings - cuts down on Bloop JSON project file size

fixes #1441
fixes #962

I don't use either of the above so hopefully this covers all the use cases.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for looking into this!

@Arthurm1
Copy link
Contributor Author

Spurious bloop.bsp.TcpBspProtocolSpec failure

@tgodzik tgodzik merged commit e5e2b11 into scalacenter:master Jan 15, 2021
assert(!hasRuntimeClasspathEntryName(resultConfig, "org.immutables"))
assert(resultConfig.project.java.isDefined)
val processorPath =
resultConfig.project.java.get.options.dropWhile(_ != "-processorpath").drop(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arthurm1 Thank you, this is the right way of adding support for annotation processors ❤️

@Arthurm1 Arthurm1 deleted the gradle_enhancements branch January 17, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants