Update coursier to 2.0.9 #1446
Merged
Update coursier to 2.0.9 #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
update-coursier
branch
4 times, most recently
from
c84ca7a to
5270783
Compare
tgodzik
force-pushed
the
update-coursier
branch
from
5270783 to
27d49ba
Compare
adpi2
reviewed
Jan 28, 2021
| @@ -506,7 +507,7 @@ def shadeSbtSettingsForModule( | |||
| }.value | |||
| }, | |||
| shadeOwnNamespaces := Set("bloop"), | |||
| shadeIgnoredNamespaces := Set("com.google.gson"), | |||
| shadeIgnoredNamespaces := Set("com.google.gson", "scala"), | |||
There was a problem hiding this comment.
Due to the collection-compat library that is brought in by coursier. It should be binary compatible and has a nice Mima job, so we should be fine, so we cna ignore it.
There was a problem hiding this comment.
Ok, but collection-compat is not the only artifact that use the scala namespace. What about the scala library?
There was a problem hiding this comment.
So that did not pop up as being a problem and it should also be binary compatible for any major version.
Besides, we are already doing it for example here: https://github.com/scalacenter/bloop/blob/master/build.sbt#L394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.