Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle improvements #1497

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

Arthurm1
Copy link
Contributor

@Arthurm1 Arthurm1 commented May 2, 2021

This should fix #1488

There's also a fix for handling latest Dotty version format from the website

Also preparation for changing tests to handle Gradle 7.0 but is blocked by gradle/gradle#17042

@Arthurm1
Copy link
Contributor Author

Arthurm1 commented May 3, 2021

Hmmm - looks like a legit failure on Mac - I'll look into it

@Arthurm1 Arthurm1 force-pushed the gradle_includeflat branch 2 times, most recently from 2274f92 to 2fafa09 Compare May 16, 2021 12:54
@Arthurm1 Arthurm1 force-pushed the gradle_includeflat branch from 2fafa09 to 19d7229 Compare May 16, 2021 16:11
@Arthurm1
Copy link
Contributor Author

Looks fine now - TcpBspProtocolSpec failing is unconnected

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@tgodzik tgodzik merged commit f599f9b into scalacenter:master May 17, 2021
@Arthurm1 Arthurm1 deleted the gradle_includeflat branch July 1, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala project within multi module Grade build utilising 'includeFlat' will not build
2 participants