Separate build integration tests and remove unused bash scripts #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would run integration tests only after all normal tests succeeded. Now, we run them separately, which has two added bonuses: - contributors can easily say if they change to integrations have failed - integration tests are always run irrelevant if the unit tests passed I also remove leftover drone tests that are no longer used.
tgodzik
force-pushed
the
separate-integrations
branch
from
9ef34eb to
567a389
Compare
|
What do you think @Arthurm1 ? I think it should be easier to debug any issues with integrations. This came up when I was trying to add tests for Maven integration. |
ckipp01
approved these changes
Jun 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would run integration tests only after all normal tests succeeded. Now, we run them separately, which has two added bonuses:
I also remove leftover drone tests that are no longer used.