Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize the community contributions #1542

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Aug 5, 2021

Previously the about message would be:

bloop v1.4.8-90-77e59d70-20210802-1858

Using Scala v2.12.8 and Zinc v1.3.0-M4+46-edbe573e
Running on Java JDK v1.8.0_292 (/usr/lib/jvm/java-8-openjdk-amd64/jre)
  -> Supports debugging user code, Java Debug Interface (JDI) is available.
Maintained by the Scala Center (Jorge Vicente Cantero, Martin Duhem)

now:

bloop v1.4.8-90-77e59d70-20210802-1858

Using Scala v2.12.8 and Zinc v1.3.0-M4+46-edbe573e
Running on Java JDK v1.8.0_292 (/usr/lib/jvm/java-8-openjdk-amd64/jre)
  -> Supports debugging user code, Java Debug Interface (JDI) is available.
Maintained by the Scala Center and the community.

Since the developers list is not actively updated and there has been a lot of community contributions I think it's a good idea to recognize it in the about message.

I also remove the twitter handle as we currently don't have an official twitter account.

Previously the about message would be:
```
bloop v1.4.8-90-77e59d70-20210802-1858

Using Scala v2.12.8 and Zinc v1.3.0-M4+46-edbe573e
Running on Java JDK v1.8.0_292 (/usr/lib/jvm/java-8-openjdk-amd64/jre)
  -> Supports debugging user code, Java Debug Interface (JDI) is available.
Maintained by the Scala Center (Jorge Vicente Cantero, Martin Duhem)
```

now:

```
bloop v1.4.8-90-77e59d70-20210802-1858

Using Scala v2.12.8 and Zinc v1.3.0-M4+46-edbe573e
Running on Java JDK v1.8.0_292 (/usr/lib/jvm/java-8-openjdk-amd64/jre)
  -> Supports debugging user code, Java Debug Interface (JDI) is available.
Maintained by the Scala Center and the community.
```

Since the developers list is not actively updated and there has been a lot of community contributions I think it's a good idea to recognize it in the about message.

I also remove the twitter handle as we currently don't have an official twitter account.
@tgodzik tgodzik requested review from adpi2, ckipp01 and sjrd August 5, 2021 15:20
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@tgodzik tgodzik merged commit e7d4e01 into scalacenter:master Aug 5, 2021
@tgodzik tgodzik deleted the community-update branch August 5, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants