Don't unnecessarily parse server handle as URI #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems ServerHandle.uri is only used for logging purposes, no need to parse it as a java.net.URI. When using Windows named pipes (like bloop bsp --protocol local --pipe \\.\pipe\foo), ServerHandle.WindowsLocal.uri crashes because of the back-slashes when trying to parse it as a URI.
alexarchambault
force-pushed
the
windows-named-pipe-error
branch
from
a0edc09 to
f2f33f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems
ServerHandle.uriis only used for logging purposes, no need to parse it as ajava.net.URI.In particular, when using Windows named pipes (like
bloop bsp --protocol local --pipe \\.\pipe\foo),ServerHandle.WindowsLocal.uricrashes because of the back-slashes when trying to parse it as a URI.