Automatically add Scala library if it's not added explicitly #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can use the Scala Maven plugin without adding any actual Scala dependencies, which will cause the Scala library to be missing. Previously, we would not be able to compile such project. Now it's possible both to compile and to resolve sources. Fixes scalacenter#1020
adpi2
reviewed
Sep 13, 2021
integrations/maven-bloop/src/main/scala/bloop/integrations/maven/MojoImplementation.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can use the Scala Maven plugin without adding any actual Scala dependencies, which will cause the Scala library to be missing.
Previously, we would not be able to compile such project. Now it's possible both to compile and to resolve sources.
Fixes #1020