Add expression evaluation for Scala 2.12 and 2.13 #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
force-pushed
the
scala-debug-adapter-2.x
branch
from
828a381 to
2b4fec2
Compare
adpi2
force-pushed
the
scala-debug-adapter-2.x
branch
13 times, most recently
from
0c26af4 to
7ad6b98
Compare
tgodzik
reviewed
Sep 17, 2021
Upgrade scala-debug-adapter to 2.0.2 For expression evaluation, the scala-debug-adapter now needs: - a set of all the class path entries to be able to map the source files to the class files - the jvm runtime - the expression compiler class loader containing the expression-compiler jar and the compiler jars Add a simple test on expression evaluation
adpi2
force-pushed
the
scala-debug-adapter-2.x
branch
from
7ad6b98 to
a747cfa
Compare
adpi2
force-pushed
the
scala-debug-adapter-2.x
branch
from
c278de9 to
ec508fc
Compare
|
@tgodzik Out of curiosity, do you know why native images are broken on 2.12.13? |
It's probably a part of Scala that is not supported on Native Image, there are ways around it with https://github.com/scalameta/sbt-native-image, but I haven't had time to look properly into that. |
tgodzik
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to scala 2.12.13 to be able to test expression evaluation. The tests were running with Scala 2.12.8 but expression evaluation is only available on Scala 2.12.10 or greater.
Upgrade scala-debug-adapter to 2.0.2, the debug server now needs:
Add a simple test on expression evaluation.
Warning: After merging this PR, Bloop debug session will no longer be compatible with the current version of Metals. scalameta/metals#2959 in Metals intends to fix this.