fix: erase scrollback when clearing the screen #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Feb 9, 2024
tgodzik
pushed a commit
to scala-cli/bloop-core
that referenced
this pull request
Mar 27, 2024
s-nel
added a commit
to s-nel/bloop
that referenced
this pull request
Jun 5, 2024
)" This reverts commit 00b715a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If during watch mode, one would scroll terminal a bit and then make changes, terminal won't be cleared fully. This results in degraded experience. This PR fixes it.
The missing erase scrollback was inspired by https://github.com/watchexec/clearscreen/blob/main/src/lib.rs#L524, which is used by cargo watch's
clearcommand.