Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace original jsonrpc4s #2483

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Oct 22, 2024

Fixes #2479

Fixes #2478

@tgodzik tgodzik marked this pull request as ready for review October 22, 2024 14:00
@tgodzik tgodzik requested a review from adpi2 October 22, 2024 14:00
@tgodzik
Copy link
Contributor Author

tgodzik commented Oct 22, 2024

CC @alexarchambault

Comment on lines +61 to +69
Dependencies.bsp4s.excludeAll(
ExclusionRule(
organization = "com.github.plokhotnyuk.jsoniter-scala"
),
ExclusionRule(
organization = "me.vican.jorge"
)
),
Dependencies.jsonrpc4s,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess we should also switch the jsonrpc4s version in build-server-protocol?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... that might be an option too, but it's only really used by Bloop currently as far as I know

@tgodzik tgodzik merged commit fa29730 into scalacenter:main Oct 22, 2024
17 checks passed
@tgodzik tgodzik deleted the replace-jsonrpc4s branch October 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fork or vendor jsonrpc4s to address bugs in it Malformed jsonrpc method not found responses
3 participants