Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Catch fatal errors when persisting zinc analysis #2516

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Nov 26, 2024

Related to scala/scala3#22026

@tgodzik tgodzik requested a review from adpi2 November 26, 2024 15:01
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there are several analysis formats in Zinc, including one that is now the default in sbt 2.x. So maybe you should try it to see if it solves your StackOverflowError.

@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 26, 2024

I know there are several analysis formats in Zinc, including one that is now the default in sbt 2.x. So maybe you should try it to see if it solves your StackOverflowError.

Hmm... might be worth just trying that snippet in sbt 2

@tgodzik tgodzik merged commit e79a78e into scalacenter:main Nov 26, 2024
17 checks passed
@tgodzik tgodzik deleted the stack-verflow branch November 26, 2024 16:06
@tgodzik
Copy link
Contributor Author

tgodzik commented Dec 4, 2024

I know there are several analysis formats in Zinc, including one that is now the default in sbt 2.x. So maybe you should try it to see if it solves your StackOverflowError.

Just checked, it fails the same on sbt 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants