Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Don't add single files to classpath #2553

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jan 2, 2025

Only jars and directories are excepted. In case of resources it will most likely be always a directory.

@crt-31
Copy link

crt-31 commented Jan 2, 2025

Suggest throwing an error (or perhaps a warning) if you filter something out

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @crt-31 that a warning would be nice to have here.

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 3, 2025

I agree with @crt-31 that a warning would be nice to have here.

I thinking that maybe we could just create a temp directory instead, so that would work nicely. I will work on that later

@tgodzik tgodzik force-pushed the dont-add-single-files branch from 9cde0c0 to e908949 Compare January 3, 2025 18:34
@tgodzik tgodzik marked this pull request as draft January 3, 2025 18:34
@tgodzik tgodzik marked this pull request as draft January 3, 2025 18:34
@tgodzik tgodzik marked this pull request as draft January 3, 2025 18:34
@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 3, 2025

Actually, it might be easier to just copy those resources, let me try work on that.

@crt-31
Copy link

crt-31 commented Jan 6, 2025

Actually, it might be easier to just copy those resources, let me try work on that.

@tgodzik, are you then planning to edit the config format so that it has a way to map the resources to specific places in the 'jar'? (I hope so :))

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 7, 2025

Actually, it might be easier to just copy those resources, let me try work on that.

@tgodzik, are you then planning to edit the config format so that it has a way to map the resources to specific places in the 'jar'? (I hope so :))

That might be hard to do though, not planning to work on it now ufortunately.

@adpi2
Copy link
Member

adpi2 commented Jan 7, 2025

@tgodzik, are you then planning to edit the config format so that it has a way to map the resources to specific places in the 'jar'? (I hope so :))

Do we have any build tool that supports this mapping from files to resource path? If not, then I don't think we need it in Bloop. In the original issue (#1631) it seems that sbt puts the resource file at the root of the jar.

@tgodzik tgodzik force-pushed the dont-add-single-files branch from e908949 to 62c3487 Compare January 7, 2025 16:48
@crt-31
Copy link

crt-31 commented Jan 7, 2025

Do we have any build tool that supports this mapping from files to resource path? If not, then I don't think we need it in Bloop. In the original issue (#1631) it seems that sbt puts the resource file at the root of the jar.

I'll try sbt later today, but I could have sworn it allowed single file resource mapping.

@tgodzik tgodzik force-pushed the dont-add-single-files branch from 62c3487 to a33d3e7 Compare January 8, 2025 18:23
@tgodzik tgodzik force-pushed the dont-add-single-files branch from a33d3e7 to b7fc29c Compare January 8, 2025 18:25
@tgodzik tgodzik requested a review from adpi2 January 8, 2025 18:27
@tgodzik tgodzik marked this pull request as ready for review January 8, 2025 18:27
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik tgodzik merged commit 490d9bc into scalacenter:main Jan 9, 2025
13 checks passed
@tgodzik tgodzik deleted the dont-add-single-files branch January 9, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants