Better support for linking SN #2567
Merged
+64
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes new options for SN linking with new configuration options added to bloop-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes new options for SN linking with new configuration options added to bloop-config. blocked by PR scalacenter/bloop-config#104 in bloop-config.
One thing I do not understand at all here is that in the tests linking with SN version 0.5 takes 5+ times longer than SN (often timing out the tests). This makes no sense to me. If anyone has any good idea about why that could be I would be very happy (it might just be some config in the generated project?).
This probably needs the eyes of someone with a bit more intimate knowledge than me of SN