Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go to super method and reveal method hierarchyto palette #275

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Apr 20, 2020

@olafurpg added this as mentioned in scalameta/metals-feature-requests#101 (comment)

Previously, I thought this wouldn't work correctly, but I tested and it seems fine.

package.json Outdated
Comment on lines 160 to 169
{
"command": "metals.super-method-hierarchy",
"category": "Metals",
"title": "Reveal super method hierachy"
},
{
"command": "metals.go-to-super-method",
"category": "Metals",
"title": "Go to super method"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add them to the list below, in order to enable them only when Metals is enabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! We actually forgot about that for some more commands. I added all of the missing ones, just left the Reveal metals view ones, since they do work without the server and still do something in that case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@tgodzik tgodzik requested a review from gabro April 20, 2020 10:40
@gabro gabro merged commit 52d8bef into scalameta:master Apr 20, 2020
@tgodzik tgodzik deleted the add-to-palette branch April 20, 2020 12:13
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this pull request Mar 29, 2023
…rn/types/node-15.0.2

Bump @types/node from 15.0.0 to 15.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants