Issue 259: use enhanced (CompletionItem|Symbol)Kinds #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this contribution @eddiemundo! I think I'll have time to review this later today, meanwhile I can suggest to add test cases to You can run |
gabro
requested changes
Apr 16, 2018
| def isFunction(symbol: Symbol): Boolean = { | ||
| val typeSymbolFullName = symbol.info.finalResultType.typeSymbol.fullName | ||
| functionTraitRegex.findFirstIn(typeSymbolFullName).isDefined | ||
| } |
There was a problem hiding this comment.
You can query the compiler directly for this piece of information with
compiler.definitions.isFunctionSymbol(
symbol.info.finalResultType.typeSymbol
)(thanks @olafurpg for the tip)
There was a problem hiding this comment.
I spent way too long trying to figure something like that out before settling on the ugly regex solution... thanks
gabro
approved these changes
Apr 16, 2018
gabro
approved these changes
Apr 16, 2018
olafurpg
approved these changes
Apr 16, 2018
olafurpg
pushed a commit
that referenced
this pull request
Feb 14, 2019
Issue 259: use enhanced (CompletionItem|Symbol)Kinds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259
I added the new lsp CompletionItemKinds and SymbolKinds.
For CompletionItemKinds I only mapped TypeParameter and Function, but I'm not sure if you want Function mapped because it's not a new CompletionItemKind, and it wasn't previously mapped. I also think the Function case is dead-code cause when trying to complete a symbol that's a function it'll probably go into the val case.
For SymbolKinds I'm not convinced that I did the additions to ScalametaEnrichments correctly. I'm not sure if documentSymbol() adds Type.Param and Lit.Null to the list that it builds, so those additional cases might be pointless.
Finally the issue mentions Constant in CompletionItemKind. I'm not sure how to map that cause doesn't CompletionItemKind.Value cover that, or does Constant mean something else?