Update Bloop to the newest nightly #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
approved these changes
Jul 29, 2021
tgodzik
force-pushed
the
update-bloop
branch
2 times, most recently
from
78ff1a8 to
63ccaa7
Compare
ckipp01
approved these changes
Jul 29, 2021
tgodzik
force-pushed
the
update-bloop
branch
8 times, most recently
from
258b86f to
13597e0
Compare
tgodzik
commented
Aug 2, 2021
| _ <- debugger.initialize | ||
| _ <- debugger.launch | ||
| _ <- debugger.configurationDone | ||
| _ <- debugger.awaitOutput("Bar\n") | ||
| _ <- debugger.disconnect |
There was a problem hiding this comment.
No need to disconnect in this test, we can just replace wait above and finish normally.
| @@ -65,7 +65,6 @@ final class Debugger(server: RemoteServer)(implicit ec: ExecutionContext) { | |||
| def disconnect: Future[Unit] = { | |||
| val args = new DisconnectArguments | |||
| args.setRestart(false) | |||
| args.setTerminateDebuggee(false) | |||
There was a problem hiding this comment.
This doesn't need to be specified, the server should take care of it appropriately.
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disconnect
| @@ -89,7 +89,7 @@ final class TestDebugger( | |||
| } | |||
|
|
|||
| def disconnect: Future[Unit] = { | |||
| ifNotFailed(debugger.disconnect) | |||
| ifNotFailed(debugger.disconnect).map(_ => terminated.trySuccess(())) | |||
There was a problem hiding this comment.
It seems that sometimes we might not get the terminated message, so this is to work around scalacenter/scala-debug-adapter#66
Merged
|
The tests started to get really flaky for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2808
Fixes #2311