Prioritize build targets with supported Scala versions. #948
+71
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if two build targets in the repo were eligible for a source file, Metals would sometimes prioritize a target with an unsupported Scala version over a target with a supported Scala version. This resulted in completions/hover/parameterHints not to work while editing cross-built sources. This PR introduces a change to the logic where we select a build target for a given source file. Now we sort the elibible candidates by two criteria: the Scala version and the platform (JVM/JS/Native). This change takes the first step towards scalameta/metals-feature-requests#13, which is about making this logic configurable.
jvican
approved these changes
Sep 27, 2019
| val isSupportedScalaVersion = scalaInfo(t).exists( | ||
| t => ScalaVersions.isSupportedScalaVersion(t.getScalaVersion()) | ||
| ) | ||
| if (isSupportedScalaVersion) score <<= 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if two build targets in the repo were eligible for a source
file, Metals would sometimes prioritize a target with an unsupported
Scala version over a target with a supported Scala version. This
resulted in completions/hover/parameterHints not to work while editing
cross-built sources.
This PR introduces a change to the logic where we select a build target
for a given source file. Now we sort the elibible candidates by two
criteria: the Scala version and the platform (JVM/JS/Native). This
change takes the first step towards
scalameta/metals-feature-requests#13, which is
about making this logic configurable.