DiffOptions: allow controlling use of ANSI markers

[kitbellew]

Also, exclude munit.internal. from MIMA.

[tgodzik]

I don't think it will work, though if someone is overriding the method it will show an error.

[kitbellew]

this provides binary compatibility (the parameters, same order) except I'm not sure if private is sufficient, too; and the new method is source-compatible.

[tgodzik]

Though if we override it wil fail the compilation or am I missing something:

trait Location
trait A{
  def locs(a: String, b: Int, l: Location): Nothing = ???
}

class B extends A{
  override def locs(a : String, b: Int)(implicit l : Location) = ???
}

This will fail, so I assume your change should also fail

[kitbellew]

i think that it wouldn't fail, or else mina would complain.

[tgodzik]

I would think so, which is why I am bit confused. It might be a bug in Mima or alternatively the code produced is binary compatible, just not source compatible.

[kitbellew]

yes, mima checks for binary. well, if there's minor source incompatibility, increasing the minor version, as you suggested, should be enough. wdyt?

[tgodzik]

I guess the odds of someone overwriting the fail method are pretty low 🤔 We should be fine then

[kitbellew]

@tgodzik thank you. i have no more changes to propose, should i release 1.1.0?

[tgodzik]

@tgodzik thank you. i have no more changes to propose, should i release 1.1.0?

Nothing from me.