Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScalafmtSbtReporter: mention scalafmt in messages #176

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

kitbellew
Copy link
Contributor

Fixes #138.

@kitbellew kitbellew requested a review from poslegm November 30, 2021 19:45
Copy link
Collaborator

@poslegm poslegm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that more clear way is creating own logger

class SbtScalafmtLogger {
  def info(message: String): Unit = log.info(s"scalafmt: $message")
  // ....
}

but for such a small amount of code this may be overkill

@kitbellew
Copy link
Contributor Author

I think that more clear way is creating own logger

class SbtScalafmtLogger {
  def info(message: String): Unit = log.info(s"scalafmt: $message")
  // ....
}

but for such a small amount of code this may be overkill

actually, it's a good idea! let me change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages from scalafmt should clearly be marked as such to not be confused with compiler error messages
2 participants