ScalafmtRunner: fix handling of trait "extends" #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, using any dialect with
allowTraitParameters = falseleads to a problem (including Scala211, Scala212 and even Scala213), and only default and Dotty dialects work correctly.Our code, in multiple places, expects the
extendskeyword to be owned by thetraittree whereas for older dialectsscalametaassigns it toName.Anonymous(which is owned byInitand only then the trait).For formatting purposes, we can leave it to the user's
scalacto determine whether this specific feature (allowTraitParameters) should be supported; enabling for formatting purposes only doesn't change how the code is parsed when this feature is not used.