Add newline instead of space if contructor is followed by a literal #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
requested changes
Aug 30, 2021
| class Toto() { | ||
| private def myScalaFmtTest(): String = { | ||
| val test = new Toto | ||
| ("test") |
There was a problem hiding this comment.
i suspect the problem here might be a little different. if you prepend ONLY to the test title, it will print both formatting details, and the rules invoked should be the same.
perhaps because of redundant paren rewrite, the statement start logic missed this case? can you add another test where the expression in parens doesn't start with a literal? a method call?
There was a problem hiding this comment.
Ach, you are right, it's redundant paren rewrite. Do we update statement starts with that rule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2712