Imports: implement contiguousGroups logic #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
force-pushed
the
2718
branch
2 times, most recently
from
f5d0d92 to
88b5711
Compare
|
@tgodzik thoughts on this? |
tgodzik
reviewed
Sep 3, 2021
docs/configuration.md
Outdated
| group at the end). Regular expressions are applied to the entire parent domain | ||
| of the import statement, up to and including the final dot. | ||
| - `rewrite.imports.contiguousGroups` (since v3.0.2): | ||
| - if `no` (default), grouping will happen on all imports within the same |
There was a problem hiding this comment.
I would honestly make it a default and not even add a setting for this. There is a high chance that val or something else between imports is there on purpose.
There was a problem hiding this comment.
i can make it default but in our codebase, we prefer to take imports spread out around the file and put them in one place. users can define their vals and then import everything.
There was a problem hiding this comment.
Ach, ok, it makes sense. But I think the default should be to not touch it, that's the safer side.
There was a problem hiding this comment.
changed the default
tgodzik
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2718.