depend not on grpc-all, but on more fine-grained dependencies #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, forgot to fix e2e |
|
Thanks for working on this. Can you also submit a PR for the docs as well (via the gh-pages branch) and to the reference example at https://github.com/xuwei-k/grpc-scala-sample ? |
|
All right |
eiennohito
added a commit
to eiennohito/grpc-scala-sample
that referenced
this pull request
May 8, 2016
To support changes in scalapb/ScalaPB#114
runtime: grpc-all -> grpc-stub tests: grpc-all -> grpc-netty
|
Okay, seems to be done. In the example project I have updated ScalPB dependency to 0.5.27, so it should be merged after the next release. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #113
Need to fix docs as well by introducing explicit dependency on a transport, otherwise default examples will stop working.