change method descriptor from private to public #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsu-chara
changed the title
matsu-chara
changed the title
grpc-java generates method descriptor as public. and it is used in official example. https://github.com/grpc/grpc-java/blob/v0.13.2/examples/src/main/java/io/grpc/examples/experimental/CompressingHelloWorldClient.java#L79
matsu-chara
force-pushed
the
method-descriptor-public
branch
from
ae8a6bb to
09784e5
Compare
thesamet
added a commit
that referenced
this pull request
Mar 21, 2016
change method descriptor from private to public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc-java generates method descriptor as
public.And it is used in official example.
https://github.com/grpc/grpc-java/blob/v0.13.2/examples/src/main/java/io/grpc/examples/experimental/CompressingHelloWorldClient.java#L79
ScalaPB genarates method descriptor as
private[this].so I want to chage it to
publicHere is the generated code
grpc-java(v0.13.2): https://gist.github.com/matsu-chara/d75d5a1ce93d9280be03#file-greetergrpc-java-L25-L32
ScalaPB(v0.5.22): https://gist.github.com/matsu-chara/d75d5a1ce93d9280be03#file-greetergrpc-scala-L5-L10