Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ScalarDB api dependency #88

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jnmt
Copy link
Contributor

@jnmt jnmt commented Sep 30, 2024

Description

This PR removes ScalarDB api dependency due to the following reasons.

  • Client SDK now exposes the ScalarDB library, so we don't have to do it here.
  • Potentially, it causes a version mismatch of libraries since ScalarDL (4.0.0-SNAPSHOT) uses a different ScalarDB version (e.g., 3.13.0 now).

Related issues and/or PRs

I guess we needed the dependency because ScalarDL Client SDK doesn't expose the ScalarDB library at that moment.

Changes made

  • Remove ScalarDB api dependency.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@jnmt jnmt self-assigned this Sep 30, 2024
@jnmt jnmt requested a review from feeblefakie September 30, 2024 02:51
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 5a2b0fa into master Oct 1, 2024
@feeblefakie feeblefakie deleted the remove-scalardb-api-dependency branch October 1, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants