-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the README.md for the linearizable ledger validation #54
Conversation
@feeblefakie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Left one minor comment.
README.md
Outdated
'scalar.dl.client.auditor.linearizable_validation.contract_id': '<choose a contract ID>', | ||
} | ||
``` | ||
and, register the [ValidateLedger](./test/ValidateLedger.class) contract as the contract ID we specified in the properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the ValidateLedger.class
, can you refer to the one in the java client SDK?
https://github.com/scalar-labs/scalardl-java-client-sdk/blob/master/src/main/java/com/scalar/dl/client/contract/ValidateLedger.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feeblefakie
Thanks for your reminder.
I revised the README 0f0f1c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This PR revises README.md to add a minor section for linearizable ledger validation.