Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README.md for the linearizable ledger validation #54

Merged
merged 5 commits into from
Nov 1, 2021

Conversation

supl
Copy link
Collaborator

@supl supl commented Oct 28, 2021

This PR revises README.md to add a minor section for linearizable ledger validation.

@supl supl requested a review from feeblefakie October 28, 2021 05:49
@supl supl self-assigned this Oct 28, 2021
@supl
Copy link
Collaborator Author

supl commented Oct 28, 2021

@feeblefakie
So sorry I forgot the README in earlier PR.
Please kindly review.

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left one minor comment.

README.md Outdated
'scalar.dl.client.auditor.linearizable_validation.contract_id': '<choose a contract ID>',
}
```
and, register the [ValidateLedger](./test/ValidateLedger.class) contract as the contract ID we specified in the properties.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feeblefakie
Thanks for your reminder.

I revised the README 0f0f1c8

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit c68f3c2 into master Nov 1, 2021
@feeblefakie feeblefakie deleted the liearizable-readme branch November 1, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants