Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #56

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Update dependencies #56

merged 1 commit into from
Nov 4, 2021

Conversation

supl
Copy link
Collaborator

@supl supl commented Nov 1, 2021

This PR updates the outdated dependency NPM packages.

@supl supl requested a review from feeblefakie November 1, 2021 04:26
@supl supl self-assigned this Nov 1, 2021
@feeblefakie
Copy link
Contributor

@supl The CI is failing. PTAL!

@supl
Copy link
Collaborator Author

supl commented Nov 4, 2021

@supl The CI is failing. PTAL!

@feeblefakie
Thanks for your reminder :)
Sorry for I didn't notice it.
I re-run the pipeline and it is fine now.

feeblefakie
feeblefakie approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

What was the issue?

@feeblefakie feeblefakie merged commit 6ef57cf into master Nov 4, 2021
@feeblefakie feeblefakie deleted the update-dependencies branch November 4, 2021 11:24
@supl
Copy link
Collaborator Author

supl commented Nov 5, 2021

LGTM! Thank you!

What was the issue?

@feeblefakie
The test application can not connect to the backend Scalar DL network.
I am thinking to review it again later to see if we can find a more stable way to start the Scalar DL network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@supl supl

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supl @feeblefakie