Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document sign-multisig command in user guide #408

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Conversation

ratik21
Copy link
Member

@ratik21 ratik21 commented Jul 8, 2021

No description provided.

@ratik21 ratik21 added algob documentation Improvements or additions to documentation labels Jul 8, 2021
@amityadav0
Copy link
Contributor

could you please add tests for sign-multisig ? i am not sure if it works, having tests before docs would be good.

@ratik21
Copy link
Member Author

ratik21 commented Jul 8, 2021

could you please add tests for sign-multisig ? i am not sure if it works, having tests before docs would be good.

This is just a basic documentation task. I have tested this command and it works, but it still feels incomplete to me. As we need to "create" multisignatures as well, which we're not doing here (we're only appending). Tests are also needed.
I added one task for test: https://www.pivotaltracker.com/story/show/178806449.

@amityadav0
Copy link
Contributor

okay, so it is working properly.

Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can create another task to create tests.

@ratik21 ratik21 merged commit 8a338f0 into develop Jul 9, 2021
@ratik21 ratik21 deleted the sign-multisig-doc branch July 9, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algob documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants