Add instructions to connect examples to distributed deployment #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrede
previously requested changes
Jun 10, 2022
ahellander
approved these changes
Jun 15, 2022
|
|
||
| ```bash | ||
| docker run -d \ |
There was a problem hiding this comment.
Lets run it interactively by deafult, so that the user gets a visual confirmation that it is working / can see the printouts.
examples/mnist-pytorch/README.md
Outdated
| -e ENTRYPOINT_OPTS=--data_path=/var/data/mnist.npz \ | ||
| --add-host=reducer:<reducer-ip> \ | ||
| --add-host=combiner:<combiner-ip> \ |
There was a problem hiding this comment.
Let's leave these out and instead make a note / warning box explaining in more detail in which situations they are needed and provide the full example there / below. .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds instructions to connect examples to remote deployment. A minor modification as also been made to the examples'
fedn.yamlin order to pass the data path. This will also bypass the docker logic such that mounting the socket won't be necessary.